add missing kms arn flag in create export sink#230
Merged
Conversation
alice-yin
commented
Aug 17, 2023
alice-yin
changed the title
alice-yin
force-pushed
the
aliceyin/add_kms_as_part_of_create_namespace_request
branch
from
ec671a8 to
564a10e
Compare
alice-yin
force-pushed
the
aliceyin/add_kms_as_part_of_create_namespace_request
branch
from
564a10e to
53a1485
Compare
shivam-ajmera
approved these changes
Aug 17, 2023
alice-yin
deleted the
aliceyin/add_kms_as_part_of_create_namespace_request
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: