Automatically populate version info for releases#237
Merged
tminusplus merged 13 commits intomainfrom Aug 30, 2023
Merged
Conversation
mattkim
reviewed
Aug 25, 2023
mattkim
reviewed
Aug 25, 2023
mattkim
reviewed
Aug 25, 2023
mattkim
reviewed
Aug 25, 2023
2 tasks
alice-yin
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This uses a combination of the DebugBuildInfo and pseudo version to ensure that we have build information both when:
go install github.com/temporalio/tcld/cmd/tcld.Part of this is updating past Go 1.18 for all the new niceness around DebugBuildInfo. Go mod tidy was also ran.
Note, that the Go behaviour is to increment the patch version when you are using an unreleased build from
go install. You can see this in the checklist wherego installrefers tov0.13.1(because it is not the v0.13.0 version) but the makefile refers tov0.13.0(even though it is not really the v0.13.0 version).Why?
Now we do not have to manually update the version with releases.
Checklist
go install github.com/temporalio/tcld/cmd/tcld@tszucs/embed-version:clean tcld: