Skip to content

Use build metadata instead of pre-release version for DefaultVersionString#248

Merged
tminusplus merged 1 commit intomainfrom
tszucs/default-version-metadata
Sep 7, 2023
Merged

Use build metadata instead of pre-release version for DefaultVersionString#248
tminusplus merged 1 commit intomainfrom
tszucs/default-version-metadata

Conversation

@tminusplus
Copy link
Copy Markdown
Contributor

@tminusplus tminusplus commented Sep 7, 2023

What was changed

Uses build metadata instead of a pre-release version for our DefaultVersionString.

Why?

Pre-release versions are parsed as less than a version without pre-release - tags in semver.

Checklist

  • Checked version string and tried using tcld to verify that the request does not return a version issue:
❯ ./tcld version
{
    "Date": "2023-09-07T19:49:07Z",
    "Commit": "cee87229532d599ede057f074089de979e6c0338-modified",
    "Version": "v0.1.3+no-version-available"
}

❯ ./tcld user get --user-email <some email>
... user details ...

@tminusplus tminusplus merged commit 49cf16b into main Sep 7, 2023
@tminusplus tminusplus deleted the tszucs/default-version-metadata branch September 7, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants