Add refresh token support for logins#258
Merged
tminusplus merged 21 commits intomainfrom May 8, 2024
Merged
Conversation
a56b51c to
e12eb0e
Compare
mattkim
reviewed
Oct 27, 2023
mattkim
reviewed
Oct 27, 2023
shakeelrao
reviewed
Oct 30, 2023
shakeelrao
reviewed
Oct 30, 2023
shakeelrao
reviewed
Oct 30, 2023
mastermanu
reviewed
May 8, 2024
mastermanu
reviewed
May 8, 2024
mastermanu
reviewed
May 8, 2024
mastermanu
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This adds refresh tokens to tcld by switching to the
golang.org/x/oauth2which supports device codes and refresh tokens.Other changes in this PR:
NewTestAppwhich sets the config dir to a temporary directory + other convenience settings.connection.gocan be tested without invoking a login.feature.goto avoid nil panics in testing.Beforecode in theNewLoginCommand, as nothing was done with the loaded login config.os.RemoveAll, to ensure a bug does not remove directories on a user's computer when the intent was to remove a single file.Why?
Allows us to shorten token access expiration times.
Checklist
golang.org/x/oauth2library.