[CLD-1637] support API key duration in days#271
Merged
shakeelrao merged 9 commits intomainfrom Oct 30, 2023
Merged
Conversation
tminusplus
approved these changes
Oct 27, 2023
Contributor
tminusplus
left a comment
tminusplus
left a comment
There was a problem hiding this comment.
Couple small comments otherwise 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
durationflag for API key creation uses time.ParseDuration, which only supports strings of the form2h45m(where hour is the highest level of granularity). However, the UI for API key creation only supports days, which is a mismatch in UX.Solution
Switch to
utils.ParseDurationwhich extendstime.ParseDurationto accept years and days.Result
Clients can specify API key expiration in days.