Skip to content

Support add replica in tcld#337

Merged
yux0 merged 4 commits intomainfrom
add-replica
Mar 9, 2024
Merged

Support add replica in tcld#337
yux0 merged 4 commits intomainfrom
add-replica

Conversation

@yux0
Copy link
Copy Markdown
Contributor

@yux0 yux0 commented Mar 5, 2024

What was changed

Support add replica in tcld

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@yux0 yux0 requested review from laniehei and mastermanu March 5, 2024 21:52
Copy link
Copy Markdown
Member

@laniehei laniehei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to not block, but have questions

Comment thread app/namespace.go Outdated
Comment thread protogen/api/common/v1/message.pb.go
Comment thread app/namespace.go
Comment thread app/namespace.go
Comment thread app/namespace.go Outdated
Comment thread app/namespace.go
@yux0 yux0 enabled auto-merge (squash) March 9, 2024 00:39
@yux0 yux0 merged commit e2af5da into main Mar 9, 2024
@yux0 yux0 deleted the add-replica branch March 9, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants