Conversation
hehaifengcn
approved these changes
May 8, 2025
Contributor
hehaifengcn
left a comment
hehaifengcn
left a comment
There was a problem hiding this comment.
seems changes contains other updates unrelated to s2c. Assume these are expected.
captainbeardo
approved these changes
May 13, 2025
Contributor
captainbeardo
left a comment
captainbeardo
left a comment
There was a problem hiding this comment.
I think the large number of changes is because people would cherry-pick the changes they need from the protos, and not commit all of the changes if it didn't affect what they were working on. This is probably fine though. There are a couple of things that are being exposed but not released, like metrics read role, but if they go to the trouble of picking the generated code out of tcld, maybe they deserve access to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Update protogen, to include latest cloud protos.
Why?
Checklist
Closes
How was this tested:
Any docs updates needed?