Decouple versioning from Temporal#175
Conversation
| const ( | ||
| ClientNameCLI = "temporal-cli" | ||
|
|
||
| CLIVersion = "1.16.1" |
There was a problem hiding this comment.
do you mean to use the SDK version?
maybe but this needs to be a separate PR to not mix goals/work items in the same PR
Though still unclear how do we release new versions of tctl then if SDK version is the same between the tctl versions?
There was a problem hiding this comment.
Oh it just seemed like maybe this was meant to be the sdk version since it’s different than the file above in the pr.
just seemed strange to have an app version and cli version and they be different.
There was a problem hiding this comment.
there are now two versions mentioned since tctl has 2 modes: default (v1.16) and opt-in new UX mode (v1.17 alpha)
| app.Name = "tctl" | ||
| app.Usage = "A command-line tool for Temporal users" | ||
| app.Version = "1.14.0-alpha.2" | ||
| app.Version = "1.17.0-alpha.1" |
There was a problem hiding this comment.
Suggestion incoming:
How do you feel about moving all these versions to a single file?
versions.go
A structure like
const (
major = "1"
minor = "17"
patch = "0"
trailer = "alpha.1" // ideally this is a commit hash coming from the build process via env or cli
release_version = major + "." + minor + "." + patch
next_version = release_version + "-" + trailer
)
There was a problem hiding this comment.
given there is going to be just one version ~ relatively soon would prefer to keep version info as is
2 participants
What was changed
Removed dependency on Temporal for versioning
Changed the new UX version to v1.17
Related PR temporalio/temporal#2715
Why?
Removing dependency on Temporal
resolve #174
resolve #160
Checklist
Closes
How was this tested:
Unit tests