Skip to content

Addressing Roey's comments#463

Merged
nadvolod merged 3 commits intotemporalio:nexus-tutorial-syncfrom
nadvolod:nexus-tutorial-sync
Mar 24, 2026
Merged

Addressing Roey's comments#463
nadvolod merged 3 commits intotemporalio:nexus-tutorial-syncfrom
nadvolod:nexus-tutorial-sync

Conversation

@nadvolod
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 23, 2026 11:50
@nadvolod nadvolod requested a review from a team as a code owner March 23, 2026 11:50
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 23, 2026

@nadvolod is attempting to deploy a commit to the Temporal Team on Vercel.

A member of the Team first needs to authorize it.

@nadvolod nadvolod changed the title Addressing Roeys comments Addressing Roey's comments Mar 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Nexus tutorial docs to incorporate review feedback, clarifying that the tutorial is specifically aligned with the Java SDK and improving formatting/readability.

Changes:

  • Updated tutorial title/description and several explanations to reference the Java SDK and Nexus usage patterns.
  • Refined terminology and expanded comparisons (tables/tips) to better explain Nexus vs alternatives.
  • Performed formatting cleanup (frontmatter arrays, admonitions, spacing, table formatting).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
docs/tutorials/nexus/sync-nexus-tutorial.md Updates tutorial narrative/content, improves formatting, and adjusts comparisons/admonitions for clarity.
docs/tutorials/nexus/index.md Normalizes frontmatter formatting and updates the page description to align with the Java SDK-focused tutorial framing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

</p>

In this walkthrough, you'll take a monolithic Temporal application — where Payments and Compliance share a single Worker — and split it into two independently deployable services connected through [Temporal Nexus](https://docs.temporal.io/nexus).
In this walkthrough, you'll take a monolithic Temporal application — where Payments and Compliance share a single namespace — and split it into two independently deployable services connected through [Temporal Nexus](https://docs.temporal.io/nexus).
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This describes the monolith coupling as sharing a namespace, but the failure domain described elsewhere in the tutorial is the shared Worker/process (and the tutorial also still states “both teams' code runs on the same Worker”). A shared namespace alone doesn’t imply Payments goes down when Compliance code crashes; the shared Worker/runtime does. Suggest changing this back to “share a single Worker/process (and namespace)” or otherwise aligning the intro to the actual coupling mechanism used in the scenario.

Suggested change
In this walkthrough, you'll take a monolithic Temporal application — where Payments and Compliance share a single namespace — and split it into two independently deployable services connected through [Temporal Nexus](https://docs.temporal.io/nexus).
In this walkthrough, you'll take a monolithic Temporal application — where Payments and Compliance share a single Worker/process (and namespace) — and split it into two independently deployable services connected through [Temporal Nexus](https://docs.temporal.io/nexus).

Copilot uses AI. Check for mistakes.
<iframe src="/html/nexus-decouple.html" width="100%" height="900" style={{border: 'none', borderRadius: '8px'}} title="Interactive: Monolith vs Nexus architecture"></iframe>

Compliance ships a bug at 3 AM. Their code crashes. But it's running on the Payments Worker — so **Payments goes down too**. Same blast radius. Same 3 AM page. Two teams, one shared fate.
Compliance ships a bug at 3 AM. Their code crashes. But it's running on the same namespace — so **Payments goes down too**. Same blast radius. Same 3 AM page. Two teams, one shared fate.
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The causal link here is incorrect: being in the same namespace does not inherently take down another team’s worker when one crashes. The blast radius described is due to running in the same Worker/process (or otherwise sharing the same runtime/deployment). Recommend revising this sentence to attribute the outage to a shared Worker/runtime (and optionally mention shared namespace as an administrative boundary, not the crash domain).

Suggested change
Compliance ships a bug at 3 AM. Their code crashes. But it's running on the same namespace — so **Payments goes down too**. Same blast radius. Same 3 AM page. Two teams, one shared fate.
Compliance ships a bug at 3 AM. Their code crashes. Because it's running in the same Worker process (within the same namespace), **Payments goes down too**. Same blast radius. Same 3 AM page. Two teams, one shared fate.

Copilot uses AI. Check for mistakes.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 23, 2026

CLA assistant check
All committers have signed the CLA.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nadvolod nadvolod merged commit cd1cce0 into temporalio:nexus-tutorial-sync Mar 24, 2026
2 of 3 checks passed
@nadvolod nadvolod deleted the nexus-tutorial-sync branch March 24, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants