Skip to content

remove go.work and binaries from source control#305

Merged
carlydf merged 1 commit intotemporalio:mainfrom
jaypipes:jaypipes/cleanup-on-aisle-three
Apr 27, 2026
Merged

remove go.work and binaries from source control#305
carlydf merged 1 commit intotemporalio:mainfrom
jaypipes:jaypipes/cleanup-on-aisle-three

Conversation

@jaypipes
Copy link
Copy Markdown
Contributor

There were two binary files in the source code repository. Removed them from source control and added them to .gitignore. Removes the go.work and go.work.sum files as well, since it's best practice to not have those in source control. Finally, moved the go-vet Github Action step from the test-integration workflow into the linters workflow since go vet is a linter. Standardized the linter steps to always cache the setup-go Github Action results.

Issue #302
Issue #303

@jaypipes jaypipes requested review from a team and jlegrone as code owners April 27, 2026 18:47
@jaypipes jaypipes force-pushed the jaypipes/cleanup-on-aisle-three branch 2 times, most recently from e3d7dc9 to a73d5e5 Compare April 27, 2026 18:54
There were two binary files in the source code repository. Removed them
from source control and added them to .gitignore. Removes the go.work
and go.work.sum files as well, since it's best practice to not have
those in source control. Finally, moved the go-vet Github Action step
from the `test-integration` workflow into the `linters` workflow since
`go vet` is a linter. Standardized the linter steps to always cache the
setup-go Github Action results.

Issue temporalio#302
Issue temporalio#303

Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
@jaypipes jaypipes force-pushed the jaypipes/cleanup-on-aisle-three branch from a73d5e5 to fa4e883 Compare April 27, 2026 20:40
Comment thread .github/workflows/test-integration.yml
@carlydf carlydf merged commit 9ff2733 into temporalio:main Apr 27, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants