Skip to content

Fix CEL to actually block deprecated resource create #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlydf merged 2 commits into from
May 1, 2026
Merged

Fix CEL to actually block deprecated resource create #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19d8445
Fix CEL to actually block deprecated resource create
carlydf May 1, 2026
8195966
Bump envtest to 1.29.0 to support optionalOldSelf CEL validation
carlydf May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Image URL to use all building/pushing image targets
IMG ?= temporal-worker-controller:latest
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.27.1
ENVTEST_K8S_VERSION = 1.29.0

MAIN_BRANCH = main
ALL_TEST_TAGS = test_dep
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/deprecated_temporalconnection_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type TemporalConnectionStatus struct {
//+kubebuilder:resource:shortName=tconn
//+kubebuilder:printcolumn:name="Host",type="string",JSONPath=".spec.hostPort",description="Temporal server endpoint"
//+kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Age"
// +kubebuilder:validation:XValidation:rule="oldSelf != null",message="TemporalConnection is deprecated and cannot be created. Use Connection instead."
// +kubebuilder:validation:XValidation:rule="oldSelf.hasValue()",message="TemporalConnection is deprecated and cannot be created. Use Connection instead.",optionalOldSelf=true
// +kubebuilder:deprecatedversion:warning="TemporalConnection is deprecated. Use Connection instead."

// TemporalConnection is the Schema for the temporalconnections API
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/deprecated_temporalworkerdeployment_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ type TemporalWorkerDeploymentStatus struct {
//+kubebuilder:printcolumn:name="Ramp %",type="number",JSONPath=".status.targetVersion.rampPercentage",description="Ramp percentage"
//+kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Age"
// +kubebuilder:validation:XValidation:rule="size(self.metadata.name) <= 63",message="name cannot be more than 63 characters"
// +kubebuilder:validation:XValidation:rule="oldSelf != null",message="TemporalWorkerDeployment is deprecated and cannot be created. Use WorkerDeployment instead."
// +kubebuilder:validation:XValidation:rule="oldSelf.hasValue()",message="TemporalWorkerDeployment is deprecated and cannot be created. Use WorkerDeployment instead.",optionalOldSelf=true
// +kubebuilder:deprecatedversion:warning="TemporalWorkerDeployment is deprecated. Use WorkerDeployment instead."

// TemporalWorkerDeployment is the Schema for the temporalworkerdeployments API
Expand Down
3 changes: 2 additions & 1 deletion helm/temporal-worker-controller-crds/templates/temporal.io_temporalconnections.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ spec:
x-kubernetes-validations:
- message: TemporalConnection is deprecated and cannot be created. Use Connection
instead.
rule: oldSelf != null
optionalOldSelf: true
rule: oldSelf.hasValue()
served: true
storage: true
subresources:
Expand Down
3 changes: 2 additions & 1 deletion helm/temporal-worker-controller-crds/templates/temporal.io_temporalworkerdeployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4216,7 +4216,8 @@ spec:
rule: size(self.metadata.name) <= 63
- message: TemporalWorkerDeployment is deprecated and cannot be created. Use
WorkerDeployment instead.
rule: oldSelf != null
optionalOldSelf: true
rule: oldSelf.hasValue()
served: true
storage: true
subresources:
Expand Down
Loading