Nexus Standalone: TerminatedFailureInfo identity#10009
Merged
stephanos merged 1 commit intofeature/nexus-standalonefrom Apr 22, 2026
Merged
Nexus Standalone: TerminatedFailureInfo identity#10009stephanos merged 1 commit intofeature/nexus-standalonefrom
stephanos merged 1 commit intofeature/nexus-standalonefrom
Conversation
stephanos
changed the title
stephanos
force-pushed
the
stephanos/sano-identity
branch
from
dda52fc to
6f659b2
Compare
stephanos
commented
Apr 22, 2026
|
|
||
| message NexusOperationTerminateState { | ||
| string request_id = 1; | ||
| string identity = 2; |
Contributor
Author
There was a problem hiding this comment.
Or should we keep that? I removed it because it's redundant info.
stephanos
force-pushed
the
stephanos/sano-identity
branch
from
6f659b2 to
b6480e7
Compare
stephanos
force-pushed
the
feature/nexus-standalone
branch
from
2e98d8b to
ee92df2
Compare
stephanos
force-pushed
the
stephanos/sano-identity
branch
2 times, most recently
from
d005a24 to
53b1eb4
Compare
stephanos
force-pushed
the
feature/nexus-standalone
branch
from
ee92df2 to
c7346c1
Compare
stephanos
force-pushed
the
stephanos/sano-identity
branch
from
53b1eb4 to
696ddd6
Compare
bergundy
approved these changes
Apr 22, 2026
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Looks great! We should get the applications components team to populate this for other archetypes.
|
|
||
| message NexusOperationTerminateState { | ||
| string request_id = 1; | ||
| string identity = 2; |
stephanos
added a commit
that referenced
this pull request
Apr 23, 2026
## What changed? Add identity to `TerminatedFailureInfo`. PS: `CanceledFailureInfo` will be a separate PR. ## Why? Allow clients to access identity via API. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
stephanos
added a commit
that referenced
this pull request
Apr 23, 2026
## What changed? Add identity to `TerminatedFailureInfo`. PS: `CanceledFailureInfo` will be a separate PR. ## Why? Allow clients to access identity via API. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
stephanos
added a commit
that referenced
this pull request
Apr 23, 2026
## What changed? Add identity to `TerminatedFailureInfo`. PS: `CanceledFailureInfo` will be a separate PR. ## Why? Allow clients to access identity via API. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
stephanos
added a commit
that referenced
this pull request
Apr 23, 2026
## What changed? Add identity to `TerminatedFailureInfo`. PS: `CanceledFailureInfo` will be a separate PR. ## Why? Allow clients to access identity via API. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
stephanos
added a commit
that referenced
this pull request
Apr 23, 2026
## What changed? Add identity to `TerminatedFailureInfo`. PS: `CanceledFailureInfo` will be a separate PR. ## Why? Allow clients to access identity via API. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
stephanos
added a commit
that referenced
this pull request
Apr 24, 2026
## What changed? Add identity to `TerminatedFailureInfo`. PS: `CanceledFailureInfo` will be a separate PR. ## Why? Allow clients to access identity via API. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
stephanos
added a commit
that referenced
this pull request
Apr 24, 2026
## What changed? Add identity to `TerminatedFailureInfo`. PS: `CanceledFailureInfo` will be a separate PR. ## Why? Allow clients to access identity via API. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
stephanos
added a commit
that referenced
this pull request
Apr 24, 2026
## What changed? Add identity to `TerminatedFailureInfo`. PS: `CanceledFailureInfo` will be a separate PR. ## Why? Allow clients to access identity via API. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add identity to
TerminatedFailureInfo.PS:
CanceledFailureInfowill be a separate PR.Why?
Allow clients to access identity via API.
How did you test it?