Add IsRateLimited to TaskAddHookDetails#10045
Open
rkannan82 wants to merge 2 commits intokannan/sync-match-result-structfrom
Open
Add IsRateLimited to TaskAddHookDetails#10045rkannan82 wants to merge 2 commits intokannan/sync-match-result-structfrom
rkannan82 wants to merge 2 commits intokannan/sync-match-result-structfrom
Conversation
This was referenced Apr 23, 2026
rkannan82
force-pushed
the
kannan/add-rate-limited-to-task-hook-v2
branch
from
a3d7db8 to
6513520
Compare
rkannan82
force-pushed
the
kannan/add-rate-limited-to-task-hook-v2
branch
from
5d2be3d to
deffb5f
Compare
Plumbs rate-limiting signal from findAndWakeMatches through the matcher stack to task lifecycle hooks, so hook consumers can distinguish tasks that were spooled due to rate limiting from normal async matches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82
force-pushed
the
kannan/add-rate-limited-to-task-hook-v2
branch
from
deffb5f to
ae105f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
IsRateLimitedtoTaskAddHookDetails, plumbing the rate-limiting signal fromfindAndWakeMatchesall throughprocessTaskAddHooks.Why
Hook consumers need to know the reason why a task was spooled -- if it is because of poller unavailability, or rate limiting.
How did you test it?
Unit tests at two levels:
matcher_datalevel: verifiesMatchTaskImmediatelyreturnsrateLimited=truewhen a poller is waiting but zero-RPS rate limit blocks the matchIsRateLimitedis set on hook details when rate-limited, and not set under normal conditions🤖 Generated with Claude Code