Decode CHASM ComponentRef in legacy callback router#10194
Open
Decode CHASM ComponentRef in legacy callback router#10194
Conversation
stephanos
commented
May 7, 2026
| } | ||
| namespaceID = ref.GetNamespaceId() | ||
| businessID = ref.GetBusinessId() | ||
| } |
Contributor
Author
There was a problem hiding this comment.
^ identical to temporal/chasm/lib/callback/request.go
stephanos
force-pushed
the
stephanos/sano-hsm-token-compat
branch
2 times, most recently
from
13cf5cd to
c5be4aa
Compare
stephanos
changed the title
stephanos
force-pushed
the
stephanos/sano-hsm-token-compat
branch
from
c5be4aa to
90767c1
Compare
stephanos
force-pushed
the
stephanos/sano-hsm-token-compat
branch
from
90767c1 to
b3ab927
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Use
ComponentRefin HSM's system callback request handler, if available and namespaceID is empty.Why?
Forward-compatibility; once clusters have upgraded to a version with this change, the next OSS release can stop dual-populating the CHASM token with HSM fields.
However;
history.enableChasmCallbacksis likely the default in the next OSS version - so maybe this is not needed?How did you test it?