Skip to content

[Scheduler] Always attempt DeleteSchedule on both stacks#10197

Merged
lina-temporal merged 3 commits intomainfrom
delete-schedule-both-stacks
May 8, 2026
Merged

[Scheduler] Always attempt DeleteSchedule on both stacks#10197
lina-temporal merged 3 commits intomainfrom
delete-schedule-both-stacks

Conversation

@lina-temporal
Copy link
Copy Markdown
Contributor

What changed?

  • Delete is now called for both CHASM/V1 stacks, as long as CHASM is enabled, regardless of success/error from CHASM stack.

Why?

  • CHASM block successfully deleting means that the V1 handler never gets a chance to run, blocking V1 deletes after a schedule has gone from V1->V2->V1 (rollback).

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@lina-temporal lina-temporal requested a review from chaptersix May 7, 2026 21:57
@lina-temporal lina-temporal requested review from a team as code owners May 7, 2026 21:58
@chaptersix
Copy link
Copy Markdown
Contributor

Additionally could you add a check for closed and return a not found from the chasm delete schedule handler?

@chaptersix
Copy link
Copy Markdown
Contributor

Additionally could you add a check for closed and return a not found from the chasm delete schedule handler?

the frontend request is not guaranteed execute to completion.

@lina-temporal lina-temporal requested a review from a team as a code owner May 8, 2026 20:39
…stacks

# Conflicts:
#	tests/schedule_migration_test.go
@lina-temporal lina-temporal enabled auto-merge (squash) May 8, 2026 20:45
@lina-temporal lina-temporal merged commit 6838cf4 into main May 8, 2026
47 checks passed
@lina-temporal lina-temporal deleted the delete-schedule-both-stacks branch May 8, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants