Ensure Handover state is removed during replication#10207
Merged
Conversation
yux0
reviewed
May 14, 2026
| } | ||
| }() | ||
|
|
||
| // ** Step 4: RecoverOrInitialize Handover (WARNING: Namespace cannot serve traffic while in this state) |
Contributor
There was a problem hiding this comment.
I think we need a workflow versioning change here. Try to use workflow.GetVersion
Contributor
Author
There was a problem hiding this comment.
Claude thinks that since it was just a defer registration it was probably fine, but I've added one just to make sure
yux0
approved these changes
May 21, 2026
stuart-wells
added a commit
that referenced
this pull request
May 22, 2026
…#10363) This reverts commit 0386366. ## What changed? Reverting Handover changes ## Why? Commit was currently breaking other builds ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Two ways to approach the same goal:
Why?
During force-failover, it is possible for a standby to be stuck in handover/unspecified state
How did you test it?