Strongly consistent Nexus endpoints lookup via dynamic config#10208
Closed
stephanos wants to merge 1 commit into
Closed
Strongly consistent Nexus endpoints lookup via dynamic config#10208stephanos wants to merge 1 commit into
stephanos wants to merge 1 commit into
Conversation
stephanos
force-pushed
the
stephanos/sano-flaky-endpoint-2
branch
2 times, most recently
from
a3edc65 to
6b82326
Compare
stephanos
changed the title
stephanos
force-pushed
the
stephanos/sano-flaky-endpoint-2
branch
2 times, most recently
from
fe97fdc to
619ca31
Compare
stephanos
commented
May 8, 2026
| 1*time.Second, | ||
| `RefreshNexusEndpointsMinWait is the minimum wait time between background long poll requests to update Nexus endpoints.`, | ||
| ) | ||
| RefreshNexusEndpointsOnReadForTest = NewGlobalBoolSetting( |
Contributor
Author
There was a problem hiding this comment.
Decided on ForTest suffix to make it very clear this is not for prod.
Contributor
There was a problem hiding this comment.
If it's not for prod, maybe it could be a test hook instead of dynamic config?
Contributor
Author
There was a problem hiding this comment.
One of the uses cases is the embedded server inside the CLI, though.
Contributor
There was a problem hiding this comment.
Yeah it may not be for prod but end users will want to set this in the dev server
stephanos
changed the title
stephanos
changed the title
stephanos
force-pushed
the
stephanos/sano-flaky-endpoint-2
branch
from
619ca31 to
3146afa
Compare
5 tasks
stephanos
force-pushed
the
stephanos/sano-flaky-endpoint-2
branch
from
3146afa to
ace3ca5
Compare
stephanos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Instead of using the cache for Nexus endpoint name lookups, always look it up via RPC when
RefreshNexusEndpointsOnReadForTestis set.See #10204 for an alternative approach.
Why?
During testing - such as functional server tests or SDK tests against the CLI - the Nexus endpoint is not always immediately available after creation. This creates friction as it requires extra retries and causes flakiness if not guarded against. This change eliminates that need.
How did you test it?