Delegate mixedbrain devserver lifecycle to Omes#10216
Draft
stephanos wants to merge 2 commits into
Draft
Conversation
stephanos
changed the title
stephanos
force-pushed
the
stephanos/omes-server-dl
branch
from
d8ef038 to
d0ba57f
Compare
stephanos
added a commit
that referenced
this pull request
May 12, 2026
Two fixes for the CI failure on PR #10216: 1. Postgres' cluster_membership.rpc_port is SMALLINT (max 32767), but omes/devserver's default port allocator picks ephemeral ports from :0 — Linux returns 32768+, which overflows. When PERSISTENCE_DRIVER is non-sqlite, pass PortBase 7230 / 7240 so the two servers use sequential low ports that fit. (Mirrors the portSetA/portSetB pins from the pre-refactor mixedbrain.) 2. Pin go.temporal.io/sdk to v1.42.0 in this sub-module via a replace. omes' go.mod ships with sdk v1.43.0, which started vendoring an internal copy of go.temporal.io/api. Linking both sdk's internal vendored proto and the external go.temporal.io/api our parent pulls in (v1.62.12-pre) panics at init() with "proto: file ... has a name conflict over temporal.api.sdk.v1.ExternalStorageReference". sdk v1.42.0 has no internal vendored copy, so no collision. Also bumps omes ref to c4036f16020e (the PortBase commit on stephanos/omes-server-dl) and refreshes omesRef accordingly.
stephanos
commented
May 12, 2026
| @@ -0,0 +1,42 @@ | |||
| module go.temporal.io/server/tests/mixedbrain | |||
Contributor
Author
There was a problem hiding this comment.
Since the dev server code now lives in Omes, we need to import Omes now. But we don't want to pull it into the top-level go.mod.
stephanos
changed the title
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stephanos
force-pushed
the
stephanos/extend-template
branch
from
cad1090 to
711bc3c
Compare
stephanos
force-pushed
the
stephanos/omes-server-dl
branch
9 times, most recently
from
6e8cd0c to
25f3b04
Compare
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stephanos
force-pushed
the
stephanos/omes-server-dl
branch
from
25f3b04 to
d15ccd9
Compare
3 tasks
stephanos
force-pushed
the
stephanos/extend-template
branch
from
711bc3c to
ab383bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Replaces the local clone/build/config/process plumbing with calls into
github.com/temporalio/omes/devserver, which now exposes a Server type that handles all of those steps.Why?
Reduce code; retain behavior.
How did you test it?