Emit payload size for UpdateWorkflowExecution requests#10223
Merged
Conversation
Mirrors activity_payload_size and schedule_payload_size, tagged with namespace and operation via the standard TelemetryInterceptor handler. Enables per-namespace querying of Workflow Update args byte volume, which header_size and per-feature payload metrics did not cover. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
spkane31
commented
May 11, 2026
spkane31
changed the title
yycptt
approved these changes
May 12, 2026
5 tasks
spkane31
added a commit
that referenced
this pull request
May 13, 2026
## What changed? Use a metrics handler without `header_callsite` tag because Prometheus rejects re-registering the same metric with a different label set and logs `error in prometheus reporter ... event_blob_size ... has different label names`. ## Why? Fix found from regression ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Fixes a regression introduced in #10223
5 tasks
spkane31
added a commit
that referenced
this pull request
May 14, 2026
## What changed? Add `WithTags(metrics.CommandType(Unspecified))` to the call sites for Workflow Update event_blob_size metric emission, which was missing in the pathch #10253 to the problem introduced in #10223 ## Why? Fixes a warning and dropped metric when the metrics handler has different shapes ## How did you test it? - [ ] built - [X] run locally and tested manually: Ran server with `make start`, created a simple workflow with an update handler, start the worker, start a workflow, and send the update. Grepped server logs for `error in prometheus reporter` and `event_blob_size` and curled the metrics endpoint `curl -s http://127.0.0.1:8000/metrics > /tmp/snapshot.txt` - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Minimal, fixing bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventBlobSizeforUpdateWorkflowExecutionrequess, tagged withnamespace.