long poll timeout constants#10246
Merged
Merged
Conversation
stephanos
force-pushed
the
stephanos/long-poll-const
branch
2 times, most recently
from
412239e to
10c7a30
Compare
stephanos
changed the title
stephanos
force-pushed
the
stephanos/long-poll-const
branch
5 times, most recently
from
88127af to
b6e53f7
Compare
stephanos
force-pushed
the
stephanos/long-poll-const
branch
from
b6e53f7 to
f4ba233
Compare
5 tasks
S15
approved these changes
May 13, 2026
Contributor
Author
|
Reverting the |
fretz12
reviewed
May 14, 2026
| var LongPollTimeout = dynamicconfig.NewNamespaceDurationSetting( | ||
| "nexusoperation.longPollTimeout", | ||
| 20*time.Second, | ||
| common.DefaultLongPollTimeout, |
Contributor
There was a problem hiding this comment.
Might want to just double check this test and see if it needs to adjusted based on the new timeout
Contributor
Author
There was a problem hiding this comment.
actually; let me address that separately
fretz12
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Introduces shared constants for default long poll timeout/buffer and applies them to SAA and SANO.
Why?
After a long internal technical discussion, 60s was determined as the default for the timeout.