Skip to content

[CHASM Visibility] Filter nil values from memo#10335

Merged
rodrigozhou merged 1 commit into
mainfrom
rodrigozhou/chasm-vis-memo-nil
May 19, 2026
Merged

[CHASM Visibility] Filter nil values from memo#10335
rodrigozhou merged 1 commit into
mainfrom
rodrigozhou/chasm-vis-memo-nil

Conversation

@rodrigozhou
Copy link
Copy Markdown
Contributor

@rodrigozhou rodrigozhou commented May 19, 2026

What changed?

Remove keys with nil value from the memo when instantiating CHASM Visibility.

Why?

nil value is used to remove keys from the memo, and it needs to match the behavior in workflows.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

@rodrigozhou rodrigozhou requested a review from a team as a code owner May 19, 2026 20:48
@rodrigozhou rodrigozhou force-pushed the rodrigozhou/chasm-vis-memo-nil branch from 099492e to 7b7c2ae Compare May 19, 2026 20:50
@rodrigozhou rodrigozhou merged commit cd87889 into main May 19, 2026
49 checks passed
@rodrigozhou rodrigozhou deleted the rodrigozhou/chasm-vis-memo-nil branch May 19, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants