Replace AddTasks Fx wrapper with history task hook#10411
Open
stephanos wants to merge 1 commit into
Open
Conversation
stephanos
force-pushed
the
stephanos/onebox-add-tasks-testhook
branch
12 times, most recently
from
4cd7cc5 to
e3aa6ab
Compare
stephanos
force-pushed
the
stephanos/onebox-add-tasks-testhook
branch
12 times, most recently
from
dffa2d5 to
8372eab
Compare
stephanos
force-pushed
the
stephanos/onebox-add-tasks-testhook
branch
from
8372eab to
84177f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Replaces the
tests/add_tasks_test.goWithFxOptionsForServiceexecutor-wrapper decoration with a focused, namespace-scoped history transfer task test hook.Why?
We want to eliminate
WithFxOptionsForServiceas it is blocking us from migrating away from theonebox.goapproach (which duplicates the fx setup) since we don't want to expose an equivalent method intemporal/fx.go.