Add CHASM test support hook#10582
Draft
stephanos wants to merge 2 commits into
Draft
Conversation
stephanos
commented
Jun 6, 2026
Comment on lines
-535
to
-537
| fx.Populate(&c.chasmEngine), | ||
| fx.Populate(&c.chasmVisibilityMgr), | ||
| fx.Populate(&c.chasmRegistry), |
Contributor
Author
There was a problem hiding this comment.
Removing these is the goal of this PR
stephanos
force-pushed
the
stephanos/chasm-test-support
branch
from
1e3ca6b to
f45324c
Compare
stephanos
force-pushed
the
stephanos/chasm-test-support
branch
from
f45324c to
f173a03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HistoryChasmTestDependenciesCreatedhook from the history serviceChasmTestDependencies()from onebox instead of populating raw CHASM engine, visibility manager, and registry refs through arbitrary Fx optionsWhy
This splits off the CHASM-specific piece of #10319 without adding broad history service refs or arbitrary Fx graph access. The hook returns only the three CHASM dependencies these tests already use.
Test plan
go test -tags test_dep ./tests -run 'TestChasmTestSuite/TestNewPayloadStore' -count=1go test -tags test_dep ./tests/xdc -run 'TestChasmSuite/TestDeleteExecution_RunningExecution' -count=1go test ./service/history -run '^$' -count=1