Merged
Conversation
|
|
Contributor
Author
|
The build is failing, but I can't see its output:
|
wxing1292
reviewed
Apr 20, 2021
wxing1292
reviewed
Apr 20, 2021
Contributor
|
the test should work after the comments are addressed |
alexshtin
reviewed
Apr 20, 2021
Contributor
alexshtin
left a comment
alexshtin
left a comment
There was a problem hiding this comment.
Thanks for contribution! Please address comments and we will merge it.
aromanovich
force-pushed
the
ipv6
branch
2 times, most recently
from
f843a5a to
573fb1f
Compare
wxing1292
reviewed
Apr 20, 2021
schema/mysql/v57/temporal/versioned/v1.5/cluster_membership.sql
Outdated
Show resolved
Hide resolved
alexshtin
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Temporal server can now listen on an IPv6 address.
Why?
I'd like to use Temporal in an IPv6-only environment.
How did you test it?
temporal-serverimage with the following env vars:temporal-webimage withTEMPORAL_GRPC_ENDPOINT=[<my-ipv6-address>]:7233I couldn't manage to run all the tests according to the manual: some of them fail with seemingly random Cassandra errors regardless of my changes.
Potential risks
I might have missed other temporal components that also rely on IP addresses being v4.
The required SQL migration will probably lock the entire
cluster_membershiptable for writes during execution, but I doubt this table ever grows large enough to make this an issue.