Create admin APIs to list timer, visibility, transfer and replication tasks #2200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
force-pushed
the
admin-api-shard-list-tasks
branch
from
5b1b1d3 to
fc03426
Compare
wxing1292
reviewed
Nov 19, 2021
Comment on lines
207
to
209
| google.protobuf.Timestamp visibility_time = 5 [(gogoproto.stdtime) = true]; | ||
| google.protobuf.Timestamp fire_time = 6 [(gogoproto.stdtime) = true]; |
Contributor
There was a problem hiding this comment.
there should be one attributes, not 2
for timer tasks, fire time / visibility time is when the task should be processed
for non timer tasks, this time attribute should be time.Unix(0,0)
wxing1292
reviewed
Nov 19, 2021
| google.protobuf.Timestamp visibility_time = 5 [(gogoproto.stdtime) = true]; | ||
| google.protobuf.Timestamp fire_time = 6 [(gogoproto.stdtime) = true]; | ||
| int64 version = 7; | ||
| } |
Contributor
There was a problem hiding this comment.
no task content? at least we should add task type information
Contributor
Author
There was a problem hiding this comment.
added task type
feedmeapples
force-pushed
the
admin-api-shard-list-tasks
branch
from
fc03426 to
2de7b6e
Compare
feedmeapples
force-pushed
the
admin-api-shard-list-tasks
branch
from
2de7b6e to
580f969
Compare
wxing1292
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
./tctl admin shard list_tasks --task_type replication --shard_id 3
./tctl admin shard list_tasks --task_type transfer --shard_id 3
./tctl admin shard list_tasks --task_type visibility --shard_id 3
Potential risks
no major risks, mostly the new API itself
Is hotfix candidate?