Migrate []byte to proto Payload#324
Merged
Merged
Conversation
alexshtin
commented
Apr 23, 2020
| dataConverter = encoded.GetDefaultDataConverter() | ||
| ) | ||
|
|
||
| func EncodeString(str string) *commonpb.Payload { |
Contributor
Author
There was a problem hiding this comment.
This is just some helpers because they are used in many places.
Contributor
There was a problem hiding this comment.
Can we change package name to payloadcodec or change this to EncodeStringToPayload?
Contributor
Author
There was a problem hiding this comment.
Moved to payload.
shawnhathaway
approved these changes
Apr 24, 2020
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package codec |
Contributor
There was a problem hiding this comment.
Thoughts on serialization code moving to temporal-proto-go? Starting to notice a bit of duplication (see Cadence merge on sdk as well for examples of this)
Contributor
Author
There was a problem hiding this comment.
Yes, we need to do something around it. Let's discuss it one day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
All user payload in proto files (mainly
details,input, andresultfields) was replaced from using[]bytetocommonpb.Payload.Why?
commonpb.Payloadhas extra metadata attached to actual data. It closes #107.How did you test it?
All automatic tests including go-sdk integration tests.
Potential risks
User data (such activity arguments and return types) will be serialized in a wrong way.