Add the ability to implement and test custom advanced visibility stores

[aromanovich]

What changed?

Two things:

• common/persistence/tests/visibility_persistence_suite_test.go renamed to visibility_persistence_suite.go, so that its VisibilityPersistenceSuite could be imported and run by the third-party package;
• VisibilityStoreFactory interface introduced. The server now accepts customVisibilityStoreFactory and invokes it if visibility store configuration points to CustomDataStoreConfig.

Why?

To be have an ability to implement and test custom advanced visibility stores.

How did you test it?
Ran Temporal tests.
Also built and ran a Temporal server with temporal.WithCustomVisibilityStoreFactory(mypackage.NewMyVisibilityStoreFactory()) option passed.

Potential risks
None.

Is hotfix candidate?
No.

[aromanovich]

@rodrigozhou, does this feature seem acceptable in principle? If yes, I would rebase and resolve conflicts so we could proceed with the review.

[rodrigozhou]

@aromanovich Yes, please. This feature sounds nice!

[aromanovich]

@rodrigozhou, done.

I would greatly appreciate if you could also take a look at #5118 — it's a bit related. Merging them would make the life of https://github.com/yandex/temporal-over-ydb a lot easier :)

[aromanovich]

Gentle bump. Just in case this got lost 🙂

[rodrigozhou]

LGTM, just added a nit comment.

[rodrigozhou]

visStore and err must be nil if it didn't enter any of those branches, so the last return should work.

[rodrigozhou]

@aromanovich
Approved, but it has conflicts with main branch again. Can you rebase it so I can merge please?

[aromanovich]

@rodrigozhou Done. Semgrep is not passing, but I'm quite sure it's not due to my rebase :)