[Reset] Add children_initialized_post_reset_point to WorkflowExecutionInfo for tracking child workflows post-reset #7194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gow
force-pushed
the
cg/reset_before_child_init_1
branch
from
57f6bb3 to
9d6e3b3
Compare
gow
force-pushed
the
cg/reset_before_child_init_1
branch
3 times, most recently
from
6015fef to
2814a46
Compare
yycptt
reviewed
Feb 4, 2025
proto/internal/temporal/server/api/persistence/v1/executions.proto
Outdated
Show resolved
Hide resolved
proto/internal/temporal/server/api/persistence/v1/executions.proto
Outdated
Show resolved
Hide resolved
proto/internal/temporal/server/api/persistence/v1/executions.proto
Outdated
Show resolved
Hide resolved
…nInfo for tracking child workflows post-reset
gow
force-pushed
the
cg/reset_before_child_init_1
branch
from
2814a46 to
695190a
Compare
yycptt
reviewed
Feb 4, 2025
proto/internal/temporal/server/api/persistence/v1/executions.proto
Outdated
Show resolved
Hide resolved
proto/internal/temporal/server/api/persistence/v1/executions.proto
Outdated
Show resolved
Hide resolved
| // This is a set of child workflows that were initialized after the reset point in the parent workflow. | ||
| // The children are identified by the key "workflow_type:workflow_id". When the parent starts to make progress after reset, it uses this data to | ||
| // determine the right start policy to apply to the child. | ||
| map<string, bool> children_initialized_post_reset_point = 102; |
Member
There was a problem hiding this comment.
Just calling out that this new field won't be replicated with today's replication stack. So the new feature will only work properly with in single dc setup
Contributor
Author
There was a problem hiding this comment.
Yes. I will be adding this and a few other fields (reset_run) to replication stack.
yycptt
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a new field
children_initialized_post_reset_pointto collect a set of children that need to be restarted after the parent is reset.Why?
We need to remember the set of children that need to be restarted after resetting a parent. So adding this field which will be populated in
workflowResetterImpl(in the followup PR)How did you test it?
Existing tests. This is just the protochange.
Potential risks
N/A
Documentation
N/A
Is hotfix candidate?
No