Add configuration to enrich Nexus operation metrics #7311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikki-dag
commented
Feb 11, 2025
nikki-dag
commented
Feb 11, 2025
nikki-dag
force-pushed
the
nikki/nexus-high-card-metrics
branch
from
3bf0a48 to
a23d333
Compare
bergundy
reviewed
Feb 11, 2025
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Thanks! Left a few small comments.
pdoerner
reviewed
Feb 11, 2025
pdoerner
approved these changes
Feb 12, 2025
bergundy
approved these changes
Feb 12, 2025
dnr
reviewed
Feb 12, 2025
dnr
reviewed
Feb 12, 2025
service/frontend/service.go
Outdated
Contributor
There was a problem hiding this comment.
This cache doesn't add anything here, it's just the identity function. Why not just use the typed setting directly?
Oops, sorry, Roey reminded me that it does avoid the mapstructure conversion, which is a small win if you need it.
Contributor
Author
There was a problem hiding this comment.
I included it following this comment. #7311 (comment)
So the cache is only for the conversion?
Co-authored-by: Roey Berman <roey.berman@gmail.com>
Co-authored-by: David Reiss <dnr@dnr.im>
nikki-dag
force-pushed
the
nikki/nexus-high-card-metrics
branch
from
152f444 to
fd29e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add configuration that controls which additional metric tags are included with Nexus operation metrics