CHASM: deserialize ChasmNode into tree node value #7538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Mar 27, 2025
| switch genericTypePrefix(fieldT) { | ||
| case chasmFieldTypePrefix: | ||
| if childNode, found := n.children[fieldN]; found { | ||
| // TODO: support chasm.Field[interface], type should go from registry |
Member
There was a problem hiding this comment.
My thinking is deserialize is dumb and always deserialize to a concrete value and cache it in the value field. The conversion to Interface can be done inside chasm.Field[Interface].Get() implementation.
Either approach works for me and your's is probably cleaner and I'd like to see how Field.Get() is implemented.
I guess what I want to avoid though is duplicated decoding. If the decoded value is already available, then just return it, because for both component and data there's only one underlying *Struct type.
yycptt
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
CHASM: deserialize
ChasmNodeinto tree nodevalue. This is only first version with few TODOs to be resolved soon.Why?
CHASM worksream.
How did you test it?
Added unit tests.
Potential risks
No risks.
Documentation
No.
Is hotfix candidate?
No.