feat: add getJWKSFromFileUri to defaultTokenKeyProvider #7626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adds support for file URI in defaultTokenKeyProvider
Why?
Planning to provide easy way as an option to use temporal in datalens OS installation without additional container for JWKS provider.
How did you test it?
Found no tests for surrounding code, can add new test files if needed.
Potential risks
Probably user should be warned in stdout that using static keys is not the best way to go.
Documentation
Nothing in current behaviour is changed, just expanding possible URIs.
Is hotfix candidate?
Definetly no.