[GHA] Validate API and SDK version in server release #7675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
rodrigozhou/gha-validate-dep-version
branch
from
cd76dba to
a87e4b2
Compare
bergundy
reviewed
Apr 30, 2025
.github/workflows/create-tag.yml
Outdated
| SEMVER_RE='^v[0-9]+\.[0-9]+\.[0-9]+$' | ||
| MODULES=( "go.temporal.io/api" "go.temporal.io/sdk" ) | ||
| for module in "${MODULES[@]}"; do | ||
| read -r _ version <<< "$(go list -m "$module")" |
Member
There was a problem hiding this comment.
This is simpler with:
go list -f '{{.Version}}' -m "$module" | grep -qP '^v\d+\.\d+\.\d+$'
You would still want to print out the version later though...
I would also check that the module isn't replaced:
go list -f '{{.Replace}}' -m "$module" | grep -q '<nil>'
a87e4b2 to
9b0a8c5
Compare
bergundy
reviewed
Apr 30, 2025
bergundy
approved these changes
Apr 30, 2025
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Please address the comment about the skep_deps_check parameter before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Validate the API and SDK versions are tagged versions.
Why?
Prevent releasing server with untagged depedencies.
How did you test it?
Potential risks
Documentation
Is hotfix candidate?