[CHASM] ExecuteSideEffectTask on Tree

[lina-temporal]

What changed?

• Added ExecuteSideEffectTask to Node, as with ExecutePureTask.

Why?

• Facilitates the remaining physical task executors.

How did you test it?

• built
• run locally and tested manually
• covered by existing tests
• added new unit test(s)
• added new functional test(s)

[lina-temporal]

Once #7855 is approved and lands in main, I'll merge main here and that should cut down on the boilerplate noise.

[yycptt]

Change for transfer & outbound queue will be in a separate PR?

[yycptt]

hmm can't really use this or at least need to change it's implementation. It's calls DescribeWorkflowExecution() which is specific for workflow.

Can you add a TODO here and create an issue to track this? No super urgent but need to get it fixed before we run chasm in production

[lina-temporal]

hmm can't really use this or at least need to change it's implementation. It's calls DescribeWorkflowExecution() which is specific for workflow.

Given that CHASM entity keys map cleanly back to workflow keys and are still written to DB as workflow executions, what prevents DescribeWorkflowExecution from working here?

[yycptt]

It's a workflow specific API and should return notFound if the requested ID is not a Workflow. Or maybe a different error type say InvalidArgument, still in that case needs to at least update the error handling logic in checkWorkflowStillExistOnSourceBeforeDiscard

[lina-temporal]

Gotcha, adding a TODO and a task.