Skip to content

Conversation

@davewhat
Copy link
Contributor

What changed?

  • force-replication workflow will no longer forward ListWorkflowExecutions() to the Active cell

Why?

  • The force-replication workflow is used to ensure all workflows are replicated from the local cell (where the workflow is run) to a target cell.
  • Part of force-replication is a call to ListWorkflowExecutions() which determines the workflows that need to be forwarded.
  • Historically this workflow was always run on the Active cell, so forwarding never occurred.
  • As of recently, we plan to run force-replication from the Passive cell.
  • For the Passive cell to know which workflows need to be forwarded, we can not have the ListWorkflowExecutions() be forwarded to the Active cell

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

…rding)

- The force-replication workflow is used to ensure all workflows are
  replicated from the local cell (where the workflow is run) to a target
  cell.
- Part of force-replication is a call to ListWorkflowExecutions() which determines
  the workflows that need to be forwarded.
- Historically this workflow was always run on the Active cell, so forwarding
  never occurred.
- As of recently, we plan to run force-replication from the Passive cell.
- For the Passive cell to know which workflows need to be forwarded, we can
  not have the ListWorkflowExecutions() be forwarded to the Active cell
@davewhat davewhat requested a review from a team as a code owner May 16, 2025 21:49
@CLAassistant
Copy link

CLAassistant commented May 16, 2025

CLA assistant check
All committers have signed the CLA.

@davewhat davewhat merged commit 51d3020 into temporalio:main May 27, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants