Change Deployment Version SA delimiter to : #7806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahabT
force-pushed
the
shahab/version-delim
branch
from
f4b1db6 to
58b3644
Compare
ShahabT
force-pushed
the
shahab/can-version
branch
from
8443fec to
251d17f
Compare
ShahabT
force-pushed
the
shahab/version-delim
branch
from
58b3644 to
e75fbb0
Compare
Shivs11
approved these changes
May 26, 2025
Member
Shivs11
left a comment
Shivs11
left a comment
There was a problem hiding this comment.
lgtm except the test change which I am not sure if you meant to include here or not
Member
There was a problem hiding this comment.
Suggested change
| // WorkerDeploymentVersionIdDelimiterV31 will be deleted once we stop supporting v32 version string fields | |
| // WorkerDeploymentVersionIdDelimiterV31 will be deleted once we stop supporting v31 version string fields |
(nit)
Member
There was a problem hiding this comment.
did u mean to have this change here?
ShahabT
force-pushed
the
shahab/version-delim
branch
2 times, most recently
from
6e3fea9 to
94ca0d3
Compare
ShahabT
force-pushed
the
shahab/version-delim
branch
from
2d2a50c to
f19170a
Compare
# Conflicts: # service/worker/workerdeployment/version_workflow.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Change Deployment Version SA delimiter from
.to:.Why?
New delimiter is used in:
TemporalWorkerDeploymentVersionSABuildIdsSA, for thepinned:<deployment name>:<build id>formatOld delimiter is used in:
We'll refactor code to clean up usage of old delimiter and string version fields later. For now, the priority is to make public preview external APIs consistent.
How did you test it?
Potential risks
If Versioning V0.31 pre-release users directly use these SAs, they wont be able to find old or new wfs if they filter using only one of the delimiters. (This affects "Go to Workflow" links in UI until UI is updated)