Skip to content

Conversation

@stephanos
Copy link
Contributor

@stephanos stephanos commented May 27, 2025

What changed?

Added a test for Update-with-Start.

Why?

Code coverage showed that there was no test for deduping a running Workflow.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Comment on lines +5349 to +5350
s.Equal(uwsRes1.response.Responses[0].GetStartWorkflow().RunId, uwsRes2.response.Responses[0].GetStartWorkflow().RunId)
s.Equal(uwsRes1.response.Responses[1].GetUpdateWorkflow().Outcome.String(), uwsRes2.response.Responses[1].GetUpdateWorkflow().Outcome.String())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@stephanos stephanos marked this pull request as ready for review May 27, 2025 02:34
@stephanos stephanos requested a review from a team as a code owner May 27, 2025 02:34
@stephanos stephanos enabled auto-merge (squash) May 27, 2025 21:53
@stephanos stephanos merged commit 8084e55 into temporalio:main May 27, 2025
53 checks passed
@stephanos stephanos deleted the uws-tests-impr branch May 27, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants