Fix nil pointer in user data replication #7818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
approved these changes
May 27, 2025
Contributor
carlydf
left a comment
carlydf
left a comment
There was a problem hiding this comment.
this makes sense to me -- sounds like you're adding tests
I'm assuming that mergedUserData is always non-nil in these two places?
dnr
changed the title
dnr
approved these changes
May 27, 2025
| if req.GetUserData().GetClock() == nil || current.GetClock() != nil && hlc.Greater(current.GetClock(), req.GetUserData().GetClock()) { | ||
| mergedData.AssignmentRules = currentVersioningData.GetAssignmentRules() | ||
| mergedData.RedirectRules = currentVersioningData.GetRedirectRules() | ||
| if mergedData != nil { |
Contributor
There was a problem hiding this comment.
This is slightly confusing: you would expect the check to be "if currentVersioningData assignment rules or redirect rules are not nil: ...", but if they are then mergedData must not be nil either, so it works (and is simpler this way).
It'll be very nice to remove V1 and V2 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
ApplyTaskQueueUserDataReplicationEvent was not handling the case when the replication data only contains Versioning V3 config.
Why?
Above
How did you test it?
Potential risks
None