Skip to content

Conversation

@stephanos
Copy link
Contributor

@stephanos stephanos commented May 28, 2025

What changed?

Always say "Update-with-Start" in the error message returned to the user when using MultiOperations.

(internally, History will still use MultiOperation in the error messages)

Why?

Users wouldn't (and shouldn't) know that Update-with-Start happens to be a MultiOperation.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

I don't expect any users to match on that string. There might be SDK tests that break now; I'll have to follow up on that.

@stephanos stephanos changed the title Don't mention MultiOperation in error Don't mention MultiOperation in Update-with-Start error May 28, 2025
@stephanos stephanos marked this pull request as ready for review May 29, 2025 00:59
@stephanos stephanos requested a review from a team as a code owner May 29, 2025 00:59
@stephanos stephanos merged commit c6bfb60 into temporalio:main May 29, 2025
55 checks passed
@stephanos stephanos deleted the multiopserr branch May 29, 2025 02:34
@drewhoskins-temporal
Copy link
Contributor

Nice developer 💌 , thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants