Skip to content

fix workflow_query_success_count tag mismatch #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShahabT merged 1 commit into from
May 30, 2025
Merged

fix workflow_query_success_count tag mismatch #7838

ShahabT merged 1 commit into from
May 30, 2025

Conversation

@ShahabT
Copy link
Contributor

@ShahabT ShahabT commented May 30, 2025 •
edited
Loading

What changed?

workflow_query_success_count was being emitted with variable tag key. fixing it.

Why?

above.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

none

@ShahabT ShahabT requested a review from prathyushpv May 30, 2025 19:49
@ShahabT ShahabT requested a review from a team as a code owner May 30, 2025 19:49
@ShahabT ShahabT enabled auto-merge (squash) May 30, 2025 19:52
@ShahabT ShahabT merged commit 7764cbd into main May 30, 2025
56 of 57 checks passed
@ShahabT ShahabT deleted the shahab/query-metric-tags branch May 30, 2025 21:33
temporal-cicd bot added a commit that referenced this pull request Jun 2, 2025
@temporal-cicd
Patch PR #7838 into cloud/v1.28.0-134
c8bbae8
@temporal-cicd temporal-cicd bot mentioned this pull request Jun 2, 2025
Merged
Shivs11 pushed a commit that referenced this pull request Jun 2, 2025
@temporal-cicd
Patch PR #7838 into cloud/v1.28.0-134 (#7850)
55e272a 
Commit changes from pull request (#7838) into cloud/v1.28.0-134
2c35593 - fix workflow_query_success_count tag mismatch

Co-authored-by: temporal-cicd[bot] <temporal-cicd[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prathyushpv prathyushpv prathyushpv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShahabT @prathyushpv