Extract server struct and add server options#826
Merged
alexshtin merged 19 commits intotemporalio:masterfrom Oct 11, 2020
Merged
Extract server struct and add server options#826alexshtin merged 19 commits intotemporalio:masterfrom
alexshtin merged 19 commits intotemporalio:masterfrom
Conversation
sergeybykov
approved these changes
Oct 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Server was extracted to the struct
ServerwithStart()andStop()methods. Server can be configured with options passed to constructor.Why?
This PR allows customers to build their own version of server with different set of dependencies (WIP).
How did you test it?
Manually run server with Go SDK integration tests and all server tests.
Potential risks
No risks. New functionality.