Add server option for overriding default TLS config provider#830
Merged
sergeybykov merged 3 commits intotemporalio:masterfrom Oct 12, 2020
Merged
Add server option for overriding default TLS config provider#830sergeybykov merged 3 commits intotemporalio:masterfrom
sergeybykov merged 3 commits intotemporalio:masterfrom
Conversation
alexshtin
reviewed
Oct 12, 2020
sergeybykov
force-pushed
the
feature/so-tls-config
branch
from
27ce003 to
8379fb8
Compare
alexshtin
approved these changes
Oct 12, 2020
Co-authored-by: Alex Shtin <alex@shtin.com>
sergeybykov
force-pushed
the
feature/so-tls-config
branch
from
8379fb8 to
ed514df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added a server option for overriding default TLS config provider. Depends on #829.
Why?
In the absence of a more flexible configuration story, this allows customers to completely override TLS configuration at the low level if needed.
How did you test it?
Manually tested that the server option when set is used by the server code.
Potential risks
I see no risk as this setting is optional and is not set by default.