Enforce minimum TLS version of 1.2#831
Merged
sergeybykov merged 3 commits intotemporalio:masterfrom Oct 12, 2020
Merged
Conversation
wxing1292
reviewed
Oct 12, 2020
wxing1292
approved these changes
Oct 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Set minimum version of the TLS protocol to 1.2.
Consolidated instantiation of
tls.Configstructs to a set of helper function for easier maintenance going forwardWhy?
To prevent connections over obsolete and insecure versions of the TLS protocol.
How did you test it?
Ran Unit tests.
Will rely on BuildKite tests for broader test coverage.
Potential risks
If some of our dependencies don't support TLS 1.2, communication might break.