Fix RespondWorkflowTaskFailed workflow termination #8725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Dec 1, 2025
Shivs11
pushed a commit
that referenced
this pull request
Dec 1, 2025
## What changed? - Properly terminate workflow in RespondWorkflowTaskFailed to flush buffered events. ## Why? - `workflow.TerminateWorkflow` util func performs failing started workflow task, flushing buffered event and terminating workflow, but it won't work properly if workflow task has already been failed. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s)
Merged
temporal-cicd bot
added a commit
that referenced
this pull request
Dec 1, 2025
Patch release 1.30.0 with PR(s): - [#8714](#8714) - [#8725](#8725) --------- Co-authored-by: Shahab Tajik <shahab@temporal.io> Co-authored-by: Shivam Saraf <shivam.saraf@temporal.io> Co-authored-by: Yichao Yang <yichao@temporal.io> Co-authored-by: temporal-cicd[bot] <temporal-cicd[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
workflow.TerminateWorkflowutil func performs failing started workflow task, flushing buffered event and terminating workflow, but it won't work properly if workflow task has already been failed.How did you test it?