Skip to content

Fix flaky test Count GroupBy#9003

Merged
awln-temporal merged 1 commit intomainfrom
chasm-vis-flaky-test-fix
Jan 12, 2026
Merged

Fix flaky test Count GroupBy#9003
awln-temporal merged 1 commit intomainfrom
chasm-vis-flaky-test-fix

Conversation

@awln-temporal
Copy link
Copy Markdown
Contributor

What changed?

Verify when all CHASM visibility executions have completed, instead of exiting when at least one execution has completed.

Why?

Counting CHASM executions with GroupBy filtering fails during test verification due to a non-deterministic verification. The current code assumes all 5 executions have been written to visibility, if CountExecutions call returns ANY value greater than 0.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@awln-temporal awln-temporal requested review from a team as code owners January 12, 2026 17:38
@awln-temporal awln-temporal requested a review from yycptt January 12, 2026 17:42
@awln-temporal awln-temporal merged commit 4791fb2 into main Jan 12, 2026
61 checks passed
@awln-temporal awln-temporal deleted the chasm-vis-flaky-test-fix branch January 12, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants