[Scheduler] Refactor CHASM scheduler tests to remove testify suite#9199
Merged
lina-temporal merged 8 commits intomainfrom Feb 18, 2026
Merged
[Scheduler] Refactor CHASM scheduler tests to remove testify suite#9199lina-temporal merged 8 commits intomainfrom
lina-temporal merged 8 commits intomainfrom
Conversation
SpecProcessor is now used without a mock throughout.
…heduler-test-refactor
chaptersix
reviewed
Feb 18, 2026
chaptersix
reviewed
Feb 18, 2026
| ValidateInvoker: func(t *testing.T, invoker *scheduler.Invoker) { | ||
| for _, start := range invoker.GetBufferedStarts() { | ||
| s.Equal(request.OverlapPolicy, start.OverlapPolicy) | ||
| require.Equal(t, request.OverlapPolicy, start.OverlapPolicy) |
Contributor
There was a problem hiding this comment.
are the stack traces easy enough to follow when this assertion fails?
Contributor
Author
There was a problem hiding this comment.
in terms of them being in a for loop or because it's in an anonymous function? Either way, I find the traces readable enough, I really just need to see what test is failing and on what assertion to start debugging.
Contributor
There was a problem hiding this comment.
yes, anonymous function and nested in runBackfillTestCase . Good with me
chaptersix
reviewed
Feb 18, 2026
chaptersix
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?