Nexus CancelCommand in CHASM#9288
Merged
stephanos merged 24 commits intotemporalio:nexus/hsm-to-chasm-migrationfrom Mar 12, 2026
Merged
Nexus CancelCommand in CHASM#9288stephanos merged 24 commits intotemporalio:nexus/hsm-to-chasm-migrationfrom
stephanos merged 24 commits intotemporalio:nexus/hsm-to-chasm-migrationfrom
Conversation
stephanos
changed the title
gow
force-pushed
the
nexus/hsm-to-chasm-migration
branch
from
d38faf1 to
44bd2ec
Compare
stephanos
force-pushed
the
nexus-chasm-cmd-cancel
branch
2 times, most recently
from
f682e20 to
f0fcdff
Compare
stephanos
changed the base branch from
nexus/hsm-to-chasm-migration
to
nexus-chasm-cmd
stephanos
changed the base branch from
nexus-chasm-cmd
to
nexus/hsm-to-chasm-migration
stephanos
force-pushed
the
nexus-chasm-cmd-cancel
branch
6 times, most recently
from
3f0512c to
449d70e
Compare
gow
force-pushed
the
nexus/hsm-to-chasm-migration
branch
from
a5a614f to
33afd1a
Compare
stephanos
force-pushed
the
nexus-chasm-cmd-cancel
branch
3 times, most recently
from
6d937d4 to
e57ae37
Compare
stephanos
commented
Mar 9, 2026
|
|
||
| var op *nexusoperation.Operation | ||
| if operationFound { | ||
| op = operationField.Get(chasmCtx) |
Contributor
Author
There was a problem hiding this comment.
The original in HSM had a TODO here
// TODO(bergundy): Remove this when operation auto-deletes itself on terminal state.
but it seems to me that this is not applicable in CHASM.
Member
There was a problem hiding this comment.
Not applicable, the operation should be deleted after completion in the CHASM implementation.
Member
There was a problem hiding this comment.
You should be able to remove this entire if statement. The operation should either be deleted or the transition to canceled is possible.
stephanos
commented
Mar 9, 2026
| }, | ||
| } | ||
| he.UserMetadata = cmd.UserMetadata | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
Just as in the schedule command handler for CHASM, Apply is not invoked here anymore.
Member
There was a problem hiding this comment.
@gow is fixing this. We discussed this and said that workflow.AddHistoryEvent is going to apply the event. All of the logic below will move to the event definition (not blocking this PR).
gow
force-pushed
the
nexus/hsm-to-chasm-migration
branch
from
33afd1a to
e80cd83
Compare
stephanos
force-pushed
the
nexus-chasm-cmd-cancel
branch
from
222edbe to
32ba391
Compare
stephanos
force-pushed
the
nexus-chasm-cmd-cancel
branch
from
32ba391 to
af6d957
Compare
stephanos
force-pushed
the
nexus-chasm-cmd-cancel
branch
from
af6d957 to
1a142c4
Compare
bergundy
approved these changes
Mar 11, 2026
| return nil, chasmErr | ||
| } | ||
| err = chasmHandler(chasmCtx, chasmWorkflow, validator, command, handlerOpts) | ||
| handledByCHASM = !errors.Is(err, chasmcommand.ErrNotSupported) |
Member
There was a problem hiding this comment.
Side note: You'll still need to handle the case where the command is RequestCancelNexusOperation and a component (nexus operation) is in the HSM tree. I see that the TODO is still in line 327.
Contributor
Author
There was a problem hiding this comment.
I'll file a reminder for this; it was originally meant to be covered by the "Migration" ticket but we deprioritized that.
stephanos
merged commit f0ba72b
into
temporalio:nexus/hsm-to-chasm-migration
45 checks passed
gow
pushed a commit
that referenced
this pull request
Mar 12, 2026
## What changed? Ported command handler for Nexus "cancel" command from HSM to CHASM. ## Why? CHASM migration. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 16, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
stephanos
added a commit
that referenced
this pull request
Mar 16, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
stephanos
added a commit
that referenced
this pull request
Mar 17, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 17, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 18, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 18, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 19, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 20, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 23, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 24, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 24, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 25, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 26, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 27, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 27, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Mar 30, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Apr 1, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
gow
pushed a commit
that referenced
this pull request
Apr 3, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
bergundy
added a commit
to bergundy/temporal
that referenced
this pull request
Apr 7, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
bergundy
added a commit
to bergundy/temporal
that referenced
this pull request
Apr 7, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
bergundy
added a commit
that referenced
this pull request
Apr 8, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
bergundy
added a commit
that referenced
this pull request
Apr 9, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
bergundy
added a commit
that referenced
this pull request
Apr 9, 2026
Ported command handler for Nexus "cancel" command from HSM to CHASM. CHASM migration. - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) --------- Co-authored-by: Roey Berman <roey.berman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Ported command handler for Nexus "cancel" command from HSM to CHASM.
Why?
CHASM migration.
How did you test it?