Add archetype metric tag and logical task processing metrics by awln-temporal · Pull Request #9377 · temporalio/temporal

awln-temporal · 2026-02-20T19:50:44Z

What changed?

Add archetype metric tag and logical task processing metrics, and add chasm_pure_task_requests and chasm_pure_task_errors metrics. Archetype metric tab will be applied for all tasks executed, physical and logical, that get added in Executable.go by default. If the archetype is found, the archetype display name will be used for the tag value. Otherwise, will default to workflow archetype.

For chasm logical pure task metrics, will resolve to __unknown__ if archetype is not found, since this would be unexpected behavior.

Why?

Components and therefore task types can be used across different archetype executions. In the future with more archetypes, there needs to be visibility for which archetype created the task for execution.

How did you test it?

yycptt · 2026-02-20T22:37:11Z

service/history/timer_queue_active_task_executor.go

 	}

 	// Execute all fired pure tasks for a component while holding the workflow lock.
+	archetypeTag := getArchetypeTagForChasmTask(task.GetArchetypeID(), t.shardContext.ChasmRegistry())


nit: we can reuse getArchetypeTag defined above?

service/history/timer_queue_active_task_executor.go

yycptt · 2026-02-20T22:41:45Z

service/history/timer_queue_active_task_executor.go

-			if err == nil {
-				processedTimers += 1
-
+			metrics.ChasmPureTaskRequests.With(t.metricsHandler).Record(1, archetypeTag)


we need to tag the pure task type as well right?

I was originally think we can do this in chasmTree.ExecutePureTask/ValidatePureTask method where the logic already looked up the registrable task based on the task instance.

moved it to the chasm framework, with metrics handler as an arg to ExecutePureTask. Immediate pure tasks will not have physical task type tag, but will still include namespace, pure task type, and archetype tag. Scheduled pure tasks via physical task queues will still have the same tags applied plus the new archetype and pure task type tag.

yycptt · 2026-02-20T22:50:38Z

service/history/queues/executable.go

ah nice. I was originally thinking we need to change every task executor implementation to return the new archetype tag. But make sense since this is called in the executable constructor and we basically a set of base tags there and archetype never changes.

We should probably rename this to baseTaskMetricTags

renamed to taskBaseMetricTags since baseTask is a bit different in my head

not renamed yet?

yycptt · 2026-02-20T22:58:18Z

service/history/queues/executable.go

I feel we no longer need this since NewExecutable will always initialize the metricHandler with the necessary tags?

yeah there's no fallbacks, all the tags will exist, removed this and all references.

hmm looks like changes for this file is not commited/pushed? I can still see defaultExecutableMetricsTags and estimateTaskMetricTags is not renamed.

pushed now, sorry about that

yycptt · 2026-03-09T22:53:57Z

chasm/tree.go


 				// Only syncStructure on next iteration if task is executed (the first return value).
-				syncStructure, err = taskNode.ExecutePureTask(context.Background(), task.attributes, task.task)
+				syncStructure, err = taskNode.ExecutePureTask(context.Background(), handler, task.attributes, task.task)


oh good catch! I already forgot we have this special immediate pure task logic 🤦

yycptt · 2026-03-09T22:59:54Z

service/history/timer_queue_task_executor_base.go

 	return processedTimers, nil
 }
+
+func getArchetypeTagForChasmTask(archetypeID chasm.ArchetypeID, chasmRegistry *chasm.Registry) metrics.Tag {


this can be removed?

yycptt · 2026-03-09T23:01:18Z

service/history/queues/executable.go

hmm looks like changes for this file is not commited/pushed? I can still see defaultExecutableMetricsTags and estimateTaskMetricTags is not renamed.

service/history/timer_queue_active_task_executor.go

yycptt · 2026-03-12T00:27:52Z

service/history/queues/executable.go

not renamed yet?

yycptt · 2026-03-12T00:35:29Z

service/history/timer_queue_active_task_executor.go

+			executed, err := executor.ExecutePureTask(ctx, t.metricsHandler, taskAttributes, taskInstance)
+			if err == nil && executed {
+				processedTimers++


revert?

Also I don't think we can have the executed check. processedTimers is probably not a good name, it's essentially for deciding if we need to do a write operation. If we have any invalid tasks, they won't be executed but we still want to a write op to delete them and create the next pure task (part of the closeTransaction logic).

dandavison

I approve the one line change in chasm/lib/callback/tasks_test.go. I haven't otherwise reviewed the PR.

…lio#9377) ## What changed? Add archetype metric tag and logical task processing metrics, and add `chasm_pure_task_requests` and `chasm_pure_task_errors` metrics. Archetype metric tab will be applied for all tasks executed, physical and logical, that get added in Executable.go by default. If the archetype is found, the archetype display name will be used for the tag value. Otherwise, will default to `workflow` archetype. For chasm logical pure task metrics, will resolve to `__unknown__` if archetype is not found, since this would be unexpected behavior. ## Why? Components and therefore task types can be used across different archetype executions. In the future with more archetypes, there needs to be visibility for which archetype created the task for execution. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [ ] added new functional test(s)

## What changed? Add archetype metric tag and logical task processing metrics, and add `chasm_pure_task_requests` and `chasm_pure_task_errors` metrics. Archetype metric tab will be applied for all tasks executed, physical and logical, that get added in Executable.go by default. If the archetype is found, the archetype display name will be used for the tag value. Otherwise, will default to `workflow` archetype. For chasm logical pure task metrics, will resolve to `__unknown__` if archetype is not found, since this would be unexpected behavior. ## Why? Components and therefore task types can be used across different archetype executions. In the future with more archetypes, there needs to be visibility for which archetype created the task for execution. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [ ] added new functional test(s)

…lio#9377) ## What changed? Add archetype metric tag and logical task processing metrics, and add `chasm_pure_task_requests` and `chasm_pure_task_errors` metrics. Archetype metric tab will be applied for all tasks executed, physical and logical, that get added in Executable.go by default. If the archetype is found, the archetype display name will be used for the tag value. Otherwise, will default to `workflow` archetype. For chasm logical pure task metrics, will resolve to `__unknown__` if archetype is not found, since this would be unexpected behavior. ## Why? Components and therefore task types can be used across different archetype executions. In the future with more archetypes, there needs to be visibility for which archetype created the task for execution. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [ ] added new functional test(s)

awln-temporal requested review from a team as code owners February 20, 2026 19:50

yycptt reviewed Feb 20, 2026

View reviewed changes

awln-temporal force-pushed the chasm-archetype-metric-tag branch from bd29336 to bacead3 Compare February 23, 2026 21:15

yycptt reviewed Mar 9, 2026

View reviewed changes

awln-temporal force-pushed the chasm-archetype-metric-tag branch from ab6b973 to ce8a938 Compare March 11, 2026 22:54

yycptt reviewed Mar 12, 2026

View reviewed changes

awln-temporal force-pushed the chasm-archetype-metric-tag branch from e559a32 to 4176e06 Compare March 12, 2026 17:09

awln-temporal requested a review from yycptt March 12, 2026 17:09

yycptt approved these changes Mar 12, 2026

View reviewed changes

awln-temporal mentioned this pull request Mar 20, 2026

Chasm archetype metric tag rerun #9607

Closed

awln-temporal requested review from a team as code owners March 25, 2026 19:11

awln-temporal requested review from a team as code owners March 26, 2026 20:26

awln-temporal force-pushed the chasm-archetype-metric-tag branch from f494b38 to 5b72162 Compare March 26, 2026 21:43

awln-temporal added 8 commits March 26, 2026 17:47

Add archetype metric tag and logical task processing metrics

7a7ec8c

Move chasm pure task metrics to framework

ae1d573

Remove default metric tags

98a7bf1

Revert unnecessary changes

a86d3b6

Rename taskBaseMetricTags

f4f11af

Fix namespace tag missing in scheduled chasm pure task execution

cc08488

Remove metricsHandler arg from ExecutePureTask

faefa8a

Add default metric tags back

f4f0bc2

awln-temporal force-pushed the chasm-archetype-metric-tag branch from 5b72162 to f4f0bc2 Compare March 26, 2026 23:22

awln-temporal added 4 commits March 27, 2026 12:17

Fix formatting

c860862

Fix shared operation metric tags for history tasks

c6867f5

Fix stale archival queue factory metrics expectation

16b57e6

Merge branch 'main' into chasm-archetype-metric-tag

b1f4484

awln-temporal added 2 commits March 27, 2026 17:35

Add archetype tag to task skipped metric

16e1f4b

Fix formatting

11e8925

dandavison approved these changes Mar 28, 2026

View reviewed changes

remove defaultMetricTags

0e7ec16

awln-temporal merged commit 87f3e35 into main Mar 30, 2026
68 of 70 checks passed

awln-temporal deleted the chasm-archetype-metric-tag branch March 30, 2026 16:20

ShahabT mentioned this pull request Apr 2, 2026

Serverless Feature Integration #9779

Merged

Conversation

awln-temporal commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed?

Why?

How did you test it?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dandavison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

awln-temporal commented Feb 20, 2026 •

edited

Loading