fix: resolve docker image tags from git and auto-detect CLI version#9411
Merged
chaptersix merged 5 commits intotemporalio:mainfrom Mar 10, 2026
Merged
Conversation
For workflow_dispatch events, GITHUB_REF and GITHUB_SHA point to the branch the workflow was dispatched from, not the ref specified in inputs.ref. This caused Docker images to be tagged with the wrong branch name and SHA. The build-docker-images composite action now resolves the ref and SHA directly from the checked-out git tree, which is correct regardless of trigger type.
chaptersix
force-pushed
the
fix/docker-build-manual-ref-mismatch
branch
from
4c3ec5c to
3572f22
Compare
chaptersix
commented
Feb 26, 2026
Extract CLI version from the downloaded binary using --version instead of relying on a manually specified input. This fixes the admin-tools OCI label showing "unknown" for the CLI version. Also removes the ref and cli-version inputs from the manual docker build workflow - users should dispatch from the target branch instead.
chaptersix
changed the title
Replace the shell-based git-info step with resolveGitInfo() in the Go helper, called as part of set-image-tags. This consolidates all ref and SHA resolution logic in one testable place.
spkane31
approved these changes
Mar 10, 2026
Contributor
spkane31
left a comment
spkane31
left a comment
There was a problem hiding this comment.
Not blocking, but few comments to consider
chaptersix
force-pushed
the
fix/docker-build-manual-ref-mismatch
branch
from
8514ef6 to
fb0bd41
Compare
- Rename shadowed err to tagErr in resolveGitInfo tag fallback - Consolidate extract-version and extract-cli-version into a single extract-binary-version command that takes binary name and output name - Use t.Fatalf instead of t.Errorf + return in tests - Add pre-release version test case (e.g. 1.31.0-151.5)
chaptersix
force-pushed
the
fix/docker-build-manual-ref-mismatch
branch
from
fb0bd41 to
97cd6cc
Compare
stephanos
pushed a commit
that referenced
this pull request
Mar 11, 2026
…9411) ## Summary - Resolve git ref and SHA from the checked-out tree (`git rev-parse`, `git symbolic-ref`) instead of `GITHUB_REF`/`GITHUB_SHA`, which point to the dispatch branch for `workflow_dispatch` events - Auto-detect CLI version from the downloaded binary via `temporal --version` fixing the admin-tools OCI label showing "unknown" - Remove `ref` input from the manual docker build workflow -- users should dispatch from the branch they want to build from
chaptersix
added a commit
to chaptersix/temporal
that referenced
this pull request
Mar 12, 2026
…emporalio#9411) ## Summary - Resolve git ref and SHA from the checked-out tree (`git rev-parse`, `git symbolic-ref`) instead of `GITHUB_REF`/`GITHUB_SHA`, which point to the dispatch branch for `workflow_dispatch` events - Auto-detect CLI version from the downloaded binary via `temporal --version` fixing the admin-tools OCI label showing "unknown" - Remove `ref` input from the manual docker build workflow -- users should dispatch from the branch they want to build from
birme
pushed a commit
to eyevinn-osaas/temporal
that referenced
this pull request
Mar 23, 2026
…emporalio#9411) ## Summary - Resolve git ref and SHA from the checked-out tree (`git rev-parse`, `git symbolic-ref`) instead of `GITHUB_REF`/`GITHUB_SHA`, which point to the dispatch branch for `workflow_dispatch` events - Auto-detect CLI version from the downloaded binary via `temporal --version` fixing the admin-tools OCI label showing "unknown" - Remove `ref` input from the manual docker build workflow -- users should dispatch from the branch they want to build from
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git rev-parse,git symbolic-ref) instead ofGITHUB_REF/GITHUB_SHA, which point to the dispatch branch forworkflow_dispatcheventstemporal --versionfixing the admin-tools OCI label showing "unknown"refinput from the manual docker build workflow -- users should dispatch from the branch they want to build from