rename package chasm/lib/workflow/commands -> chasm/lib/workflow/workflowregistry#9474
Open
gow wants to merge 4 commits intonexus/hsm-to-chasm-migrationfrom
Open
rename package chasm/lib/workflow/commands -> chasm/lib/workflow/workflowregistry#9474gow wants to merge 4 commits intonexus/hsm-to-chasm-migrationfrom
gow wants to merge 4 commits intonexus/hsm-to-chasm-migrationfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
gow
force-pushed
the
cg/nexus/history_events_registry_1
branch
from
e407480 to
f384291
Compare
gow
force-pushed
the
nexus/hsm-to-chasm-migration
branch
from
f0ba72b to
c4c868f
Compare
gow
force-pushed
the
cg/nexus/history_events_registry_1
branch
from
f384291 to
d3e600d
Compare
5 tasks
bergundy
reviewed
Mar 12, 2026
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
I would also rename Registry.Register to Registry.RegisterCommandHandler
service/history/api/respondworkflowtaskcompleted/workflow_task_completed_handler.go
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Suggested change
| if chasmHandler, ok := handler.chasmWorkflowRegistry.CommandHandler(command.GetCommandType()); ok { |
service/history/api/respondworkflowtaskcompleted/workflow_task_completed_handler.go
Outdated
Show resolved
Hide resolved
gow
force-pushed
the
nexus/hsm-to-chasm-migration
branch
from
a5b9a45 to
3cb6ca5
Compare
gow
force-pushed
the
cg/nexus/history_events_registry_1
branch
from
d3e600d to
6509cde
Compare
gow
force-pushed
the
nexus/hsm-to-chasm-migration
branch
from
3cb6ca5 to
4ca6b5a
Compare
gow
force-pushed
the
cg/nexus/history_events_registry_1
branch
from
6509cde to
9c5b648
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Just a package rename. No other code change.
Why?
Migrating Nexus from HSM to CHASM
How did you test it?
Note
Low Risk
Primarily a package/API rename and dependency wiring update; low behavioral risk, but broad mechanical changes could cause compile-time breakage if any call sites were missed.
Overview
Renames the CHASM workflow command registry package from
chasm/lib/workflow/commandtochasm/lib/workflow/workflowregistryand updates its public API (RegisterCommandHandler,CommandHandler,CommandHandlerOptions,ErrCommandNotSupported).Propagates the rename through Nexus operation command handlers/tests, History
RespondWorkflowTaskCompletedCHASM fallback path, engine/fx wiring, and related Nexus components so CHASM command handling continues to resolve and invoke handlers via the new registry.Written by Cursor Bugbot for commit e4740af. This will update automatically on new commits. Configure here.