Conversation
stephanos
commented
Mar 13, 2026
| true, | ||
| `Toggles all Nexus functionality on the server. Note that toggling this requires restarting server hosts for it | ||
| to take effect.`, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This is the main change
stephanos
force-pushed
the
stephanos/rm-nexus-ff
branch
3 times, most recently
from
3d05f48 to
2ffac27
Compare
stephanos
commented
Mar 13, 2026
| } | ||
|
|
||
| s.logger.Warn(fmt.Sprintf("system.enableNexus dynamic config is enabled but the HTTP API port has not been set. Starting with Nexus disabled. %s", action)) | ||
| s.logger.Warn(fmt.Sprintf("HTTP API port has not been set. Nexus HTTP endpoints will not be available. %s", action)) |
Contributor
Author
There was a problem hiding this comment.
Is this the right framing?
stephanos
force-pushed
the
stephanos/rm-nexus-ff
branch
from
2ffac27 to
1ccf4d6
Compare
bergundy
approved these changes
Mar 13, 2026
| var action string | ||
| if os.Args[0] == "temporal" { | ||
| action = "To enable Nexus, start the server with: `temporal server start-dev --http-port 7243 --dynamic-config-value system.enableNexus=true`." | ||
| action = "To enable Nexus, start the server with: `temporal server start-dev --http-port 7243`." |
Member
There was a problem hiding this comment.
This isn't necessary anymore, CLI will enable HTTP by default. Just remove this branch.
| } | ||
|
|
||
| s.logger.Warn(fmt.Sprintf("system.enableNexus dynamic config is enabled but the HTTP API port has not been set. Starting with Nexus disabled. %s", action)) | ||
| s.logger.Warn(fmt.Sprintf("HTTP API port has not been set. Nexus HTTP endpoints will not be available. %s", action)) |
birme
pushed a commit
to eyevinn-osaas/temporal
that referenced
this pull request
Mar 23, 2026
## What changed? Deleted `"system.enableNexus"`. ## Why? Nexus has been GA since Dec 2024. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Deleted
"system.enableNexus".Why?
Nexus has been GA since Dec 2024.
How did you test it?